Skip to content

Feat: Add Str(Cow<'static, str>) to InvalidTransaction error enum#2998

Merged
rakita merged 2 commits intobluealloy:mainfrom
developeruche:feat/str-cow-error
Sep 22, 2025
Merged

Feat: Add Str(Cow<'static, str>) to InvalidTransaction error enum#2998
rakita merged 2 commits intobluealloy:mainfrom
developeruche:feat/str-cow-error

Conversation

@developeruche
Copy link
Contributor

Closes #2995

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for ci

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 19, 2025

CodSpeed Performance Report

Merging #2998 will degrade performances by 4.6%

Comparing developeruche:feat/str-cow-error (0a3d77b) with main (591ee99)

Summary

❌ 1 regression
✅ 172 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
snailtracer-inspect 386 ms 404.6 ms -4.6%

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regresion is not related to the change

@rakita rakita merged commit 426ffb3 into bluealloy:main Sep 22, 2025
30 of 31 checks passed
@github-actions github-actions bot mentioned this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Str(&'str) to InvalidTransaction error enum

2 participants