Set l2_block in try_fetch for pre-Isthmus forks; add reload tests#2994
Merged
rakita merged 2 commits intobluealloy:mainfrom Sep 18, 2025
Merged
Conversation
CodSpeed Performance ReportMerging #2994 will improve performances by 3.3%Comparing Summary
Benchmarks breakdown
|
Merged
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 21, 2026
…uealloy/revm#2994) * Update l1block.rs * Update handler.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set l2_block in L1BlockInfo::try_fetch for Bedrock/Regolith and Ecotone (pre-Isthmus) branches to align caching/reload semantics with Isthmus.
Reason: OpHandler checks ctx.chain().l2_block != block_number to decide whether to reload. When l2_block was left at U256::ZERO pre-Isthmus, the handler reloaded on every non-deposit tx within the same block, defeating the intended cache and causing redundant DB fetches.
This change ensures consistent behavior across forks, reduces unnecessary DB reads, and matches the documented intent (“reloaded if not current block”).
Add tests mirroring the Isthmus case to verify reload behavior for Regolith and Ecotone pre-Isthmus: