Skip to content

Comments

feat: Introduced all_mut and all functions to ContextTr#2992

Merged
rakita merged 6 commits intobluealloy:mainfrom
developeruche:feat/context-all
Sep 18, 2025
Merged

feat: Introduced all_mut and all functions to ContextTr#2992
rakita merged 6 commits intobluealloy:mainfrom
developeruche:feat/context-all

Conversation

@developeruche
Copy link
Contributor

closes #2988

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 18, 2025

CodSpeed Performance Report

Merging #2992 will not alter performance

Comparing developeruche:feat/context-all (852e289) with main (372f303)

Summary

✅ 173 untouched

@developeruche
Copy link
Contributor Author

Couldn't add db_mut to all_mut because of the shared mutable ref to journaled_state, settle for a default impl

@rakita
Copy link
Member

rakita commented Sep 18, 2025

Couldn't add db_mut to all_mut because of the shared mutable ref to journaled_state, settle for a default impl

Makes sense, db is part of journal

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit

@@ -56,63 +56,47 @@ impl<
type Local = LOCAL;

#[inline]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#[inline] have been applied

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rakita rakita merged commit 5b0d6f8 into bluealloy:main Sep 18, 2025
31 checks passed
@github-actions github-actions bot mentioned this pull request Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Idea for ContextTr, create a all_mut and all functions

2 participants