fix race in global crypto provider installation using OnceLock::set#2986
Closed
vtjl10 wants to merge 3 commits intobluealloy:mainfrom
Closed
fix race in global crypto provider installation using OnceLock::set#2986vtjl10 wants to merge 3 commits intobluealloy:mainfrom
vtjl10 wants to merge 3 commits intobluealloy:mainfrom
Conversation
Contributor
vtjl10
commented
Sep 17, 2025
- Summary: Replace racy install_crypto logic with atomic OnceLock::set to ensure accurate success reporting under contention.
- Problem: install_crypto could return true even if another thread initialized CRYPTO first.
- Solution: Use OnceLock::set(...).is_ok(); add set to the no_std OnceLock wrapper for consistent API.
- Changes:
- primitives: add OnceLock::set in no_std wrapper; std path delegates to std::sync::OnceLock::set
- precompile/interface: rewrite install_crypto to return CRYPTO.set(...).is_ok()
CodSpeed Performance ReportMerging #2986 will not alter performanceComparing Summary
|
Member
|
Superseded by #2997 thank you for finding it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.