feat: allow EIP-7623 to be disabled#2985
Merged
rakita merged 3 commits intobluealloy:mainfrom Sep 18, 2025
Merged
Conversation
rodibozman
commented
Sep 17, 2025
rodibozman
force-pushed
the
rodi@cfg-eip-7623
branch
2 times, most recently
from
65c0b7e to
1dadf62
Compare
CodSpeed Performance ReportMerging #2985 will not alter performanceComparing Summary
|
rodibozman
force-pushed
the
rodi@cfg-eip-7623
branch
4 times, most recently
from
fd6bc11 to
0787292
Compare
rodibozman
force-pushed
the
rodi@cfg-eip-7623
branch
from
0787292 to
c311052
Compare
Contributor
Author
rakita
reviewed
Sep 18, 2025
crates/interpreter/src/gas/calc.rs
Outdated
| access_list_accounts: u64, | ||
| access_list_storages: u64, | ||
| authorization_list_num: u64, | ||
| is_eip7623_disabled: bool, |
Member
There was a problem hiding this comment.
Lets do it differently, and make a change only in the place where this function is called. So we dont need to propagate this flag this deep
Member
There was a problem hiding this comment.
In validate_initial_tx_gas function
Contributor
Author
There was a problem hiding this comment.
I reduced the scope of the code.
I had to at least propagate the flag to validate_initial_tx_gas from validate otherwise if GasFloorMoreThanGasLimit is raised I'm loosing the information about the initial_gas in validate_initial_tx_gas from handler.
Let me know if you had something else in mind.
rodibozman
force-pushed
the
rodi@cfg-eip-7623
branch
from
c311052 to
9397bbd
Compare
rakita
reviewed
Sep 18, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2936.
Let me know if I missed something or if you want me to add a line in a CHANGELOG.
(cc @rakita)