Add an option to disable "fee-charge" on op-revm#2980
Merged
rakita merged 1 commit intobluealloy:mainfrom Sep 17, 2025
Merged
Conversation
An option to disable fee charges, only meaningful on `op-revm` is added, which doesn't charge additional fees, in addition from the default fee from the gas limit and gas price. This is useful for `eth_call`s which should disable all fees. See paradigmxyz/reth#18470
1 task
CodSpeed Performance ReportMerging #2980 will not alter performanceComparing Summary
|
mattsse
approved these changes
Sep 16, 2025
|
|
||
| // The L1-cost fee is only computed for Optimism non-deposit transactions. | ||
| if !is_deposit { | ||
| if !is_deposit && !ctx.cfg().is_fee_charge_disabled() { |
rakita
approved these changes
Sep 17, 2025
Member
rakita
left a comment
rakita
left a comment
There was a problem hiding this comment.
Would introduce configurable flags in the future, but for the sake of moving forward/unblocking this lgtm
Merged
rakita
pushed a commit
that referenced
this pull request
Sep 23, 2025
) An option to disable fee charges, only meaningful on `op-revm` is added, which doesn't charge additional fees, in addition from the default fee from the gas limit and gas price. This is useful for `eth_call`s which should disable all fees. See paradigmxyz/reth#18470
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 21, 2026
…uealloy/revm#2980) An option to disable fee charges, only meaningful on `op-revm` is added, which doesn't charge additional fees, in addition from the default fee from the gas limit and gas price. This is useful for `eth_call`s which should disable all fees. See paradigmxyz/reth#18470
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An option to disable fee charges, only meaningful on
op-revmis added, which doesn't charge additional fees, in addition from the default fee from the gas limit and gas price.This is useful for
eth_calls which should disable all fees.See paradigmxyz/reth#18470