Fix infinite recursion in EthPrecompiles PrecompileProvider methods#2962
Merged
rakita merged 2 commits intobluealloy:mainfrom Sep 12, 2025
Merged
Fix infinite recursion in EthPrecompiles PrecompileProvider methods#2962rakita merged 2 commits intobluealloy:mainfrom
rakita merged 2 commits intobluealloy:mainfrom
Conversation
CodSpeed Performance ReportMerging #2962 will not alter performanceComparing Summary
|
mattsse
requested changes
Sep 11, 2025
Collaborator
mattsse
left a comment
There was a problem hiding this comment.
this should use fully qualified syntax instead Self::<>(self, ..)
mattsse
approved these changes
Sep 11, 2025
Contributor
Author
|
@mattsse merge? |
rakita
approved these changes
Sep 12, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
warm_addressesandcontainswith proper delegation toprecompiles.crates/handler/src/precompile_provider.rsChanges
warm_addressesnow returnsBox::new(self.precompiles.addresses().cloned()).containsnow callsself.precompiles.contains(address).Impact