chore(inspector): remove dead skip flag#2951
Merged
rakita merged 1 commit intobluealloy:mainfrom Sep 9, 2025
Merged
Conversation
The skip flag was never set anywhere and only read in step_end, making it dead code. Removing it simplifies the tracer, avoids confusion about unimplemented behavior, and aligns with EIP-3155 which expects an entry per operation (there’s no need to conditionally skip output).
Member
|
wainting for CI before merging |
CodSpeed Performance ReportMerging #2951 will not alter performanceComparing Summary
Footnotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The skip flag was never set anywhere and only read in step_end, making it dead code. Removing it simplifies the tracer, avoids confusion about unimplemented behavior, and aligns with EIP-3155 which expects an entry per operation (there’s no need to conditionally skip output).