Skip to content

Comments

chore(inspector): remove dead skip flag#2951

Merged
rakita merged 1 commit intobluealloy:mainfrom
MozirDmitriy:chore/remove-dead-skip-flag-eip3155
Sep 9, 2025
Merged

chore(inspector): remove dead skip flag#2951
rakita merged 1 commit intobluealloy:mainfrom
MozirDmitriy:chore/remove-dead-skip-flag-eip3155

Conversation

@MozirDmitriy
Copy link
Contributor

The skip flag was never set anywhere and only read in step_end, making it dead code. Removing it simplifies the tracer, avoids confusion about unimplemented behavior, and aligns with EIP-3155 which expects an entry per operation (there’s no need to conditionally skip output).

The skip flag was never set anywhere and only read in step_end, making it dead code. Removing it simplifies the tracer, avoids confusion about unimplemented behavior, and aligns with EIP-3155 which expects an entry per operation (there’s no need to conditionally skip output).
Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find

@rakita
Copy link
Member

rakita commented Sep 9, 2025

wainting for CI before merging

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 9, 2025

CodSpeed Performance Report

Merging #2951 will not alter performance

Comparing MozirDmitriy:chore/remove-dead-skip-flag-eip3155 (892ee97) with main (2d79c28)1

Summary

✅ 173 untouched benchmarks

Footnotes

  1. No successful run was found on main (a5fbd07) during the generation of this report, so 2d79c28 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@rakita rakita merged commit ec522c7 into bluealloy:main Sep 9, 2025
31 checks passed
This was referenced Sep 9, 2025
@MozirDmitriy MozirDmitriy deleted the chore/remove-dead-skip-flag-eip3155 branch October 8, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants