Skip to content

Comments

Avoid panic on non-UTF filenames in statetest runner#2948

Merged
rakita merged 3 commits intobluealloy:mainfrom
prestoalvarez:main
Sep 9, 2025
Merged

Avoid panic on non-UTF filenames in statetest runner#2948
rakita merged 3 commits intobluealloy:mainfrom
prestoalvarez:main

Conversation

@prestoalvarez
Copy link
Contributor

Description

  • Summary: Replace unsafe file_name().unwrap().to_str().unwrap() with a safe check in skip_test to prevent panics on non-UTF or missing filenames.
  • Change: In bins/revme/src/cmd/statetest/runner.rs, use and_then(|s| s.to_str()) with early return (false) if the name is invalid. Added a brief comment.
  • Rationale: CLI should not crash on valid Unix paths with non-UTF names; default behavior is to not skip when the filename is unknown.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 8, 2025

CodSpeed Performance Report

Merging #2948 will not alter performance

Comparing prestoalvarez:main (2e62120) with main (36cae77)

Summary

✅ 173 untouched benchmarks

Co-authored-by: rakita <rakita@users.noreply.github.com>
@rakita rakita merged commit adf2aea into bluealloy:main Sep 9, 2025
31 checks passed
This was referenced Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants