Skip to content

Comments

chore(op-revm): rm redundant phantom#2943

Merged
rakita merged 1 commit intobluealloy:mainfrom
nkysg:re_ophandler_phantom
Sep 8, 2025
Merged

chore(op-revm): rm redundant phantom#2943
rakita merged 1 commit intobluealloy:mainfrom
nkysg:re_ophandler_phantom

Conversation

@nkysg
Copy link
Contributor

@nkysg nkysg commented Sep 6, 2025

#[derive(Debug, Clone)]
pub struct MainnetHandler<CTX, ERROR, FRAME> {
/// Phantom data to hold the generic type parameters.
pub _phantom: core::marker::PhantomData<(CTX, ERROR, FRAME)>,
}

MainnetHandler already uses _phantom

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 6, 2025

CodSpeed Performance Report

Merging #2943 will not alter performance

Comparing nkysg:re_ophandler_phantom (8617c20) with main (4d24789)

Summary

✅ 173 untouched benchmarks

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@rakita rakita merged commit c6cf17b into bluealloy:main Sep 8, 2025
31 checks passed
This was referenced Sep 5, 2025
@nkysg nkysg deleted the re_ophandler_phantom branch September 8, 2025 08:32
This was referenced Sep 9, 2025
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants