fix(handler): correct transaction ID decrement logic#2892
Merged
rakita merged 1 commit intobluealloy:mainfrom Aug 17, 2025
Merged
fix(handler): correct transaction ID decrement logic#2892rakita merged 1 commit intobluealloy:mainfrom
rakita merged 1 commit intobluealloy:mainfrom
Conversation
jackwener
commented
Aug 17, 2025
|
|
||
| // decrement transaction id as it was incremented when we discarded the tx. | ||
| acc.transaction_id -= acc.transaction_id; | ||
| acc.transaction_id -= 1; |
Contributor
Author
There was a problem hiding this comment.
acc.transaction_id always is 0
CodSpeed Performance ReportMerging #2892 will not alter performanceComparing Summary
|
rakita
approved these changes
Aug 17, 2025
Closed
Merged
lwedge99
pushed a commit
to sentioxyz/revm
that referenced
this pull request
Sep 16, 2025
Co-authored-by: megakabi <jakevin@megatechnology.com>
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 21, 2026
…2892) Co-authored-by: megakabi <jakevin@megatechnology.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.