feat: short address for journal cold/warm check#2849
Merged
Conversation
rakita
force-pushed
the
rakita/journal_short_address_perf
branch
from
c100b21 to
1b832f7
Compare
CodSpeed Performance ReportMerging #2849 will improve performances by 3.01%Comparing Summary
Benchmarks breakdown
|
rakita
force-pushed
the
rakita/journal_short_address_perf
branch
from
278df4e to
0823edd
Compare
DaniPopes
reviewed
Aug 6, 2025
| // Clear coinbase address warming for next tx | ||
| *warm_coinbase_address = None; | ||
| reset_preloaded_addresses(warm_preloaded_addresses, precompiles); | ||
| warm_addresses.clear_coinbase(); |
Collaborator
There was a problem hiding this comment.
this doesn't clear precompiles anymore?
Collaborator
There was a problem hiding this comment.
i guess it's always reset in set_precompile_addresses
Member
Author
There was a problem hiding this comment.
set_precompile_addresses will reset it, and it is only called on spec_id change or if precompile address is empty.
Merged
Collaborator
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added optimisation for precompile short address access. This is an extension of #2846
Previously access list account was not loaded from database but inserted into the warm_accounts hashset. This made sense if the account from the access list is not accessed in execution. This PR switches this behaviour and always loads all access lists at the start to mark the warm.