feat: rename bn128 to bn254 for Ethereum standard consistency#2810
Merged
rakita merged 3 commits intobluealloy:mainfrom Jul 28, 2025
Merged
feat: rename bn128 to bn254 for Ethereum standard consistency#2810rakita merged 3 commits intobluealloy:mainfrom
rakita merged 3 commits intobluealloy:mainfrom
Conversation
CodSpeed Performance ReportMerging #2810 will degrade performances by 4.01%Comparing Summary
Benchmarks breakdown
|
kevaundray
reviewed
Jul 26, 2025
crates/op-revm/src/precompiles.rs
Outdated
| @@ -70,7 +70,7 @@ pub fn granite() -> &'static Precompiles { | |||
| INSTANCE.get_or_init(|| { | |||
| let mut precompiles = fjord().clone(); | |||
| // Restrict bn256Pairing input size | |||
Contributor
There was a problem hiding this comment.
can you also grep for bn256 and change that to bn254?
kevaundray
reviewed
Jul 26, 2025
Comment on lines
119
to
120
| // EIP-196: Precompiled contracts for addition and scalar multiplication on the elliptic curve alt_bn128. | ||
| // EIP-197: Precompiled contracts for optimal ate pairing check on the elliptic curve alt_bn128. |
Contributor
There was a problem hiding this comment.
Instead of alt_bn254, it should just be bn254
Member
There was a problem hiding this comment.
This is exactly how the EIP is named, so I would leave it
kevaundray
reviewed
Jul 26, 2025
Contributor
kevaundray
left a comment
kevaundray
left a comment
There was a problem hiding this comment.
Left some comments, though essentially the change should be:
- bn256 -> bn254
- alt_bn128 -> bn254
- bn128 -> bn254
rakita
reviewed
Jul 28, 2025
rakita
reviewed
Jul 28, 2025
rakita
reviewed
Jul 28, 2025
rakita
reviewed
Jul 28, 2025
rakita
approved these changes
Jul 28, 2025
Closed
This was referenced Jul 28, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Merged
lwedge99
pushed a commit
to sentioxyz/revm
that referenced
this pull request
Sep 16, 2025
…loy#2810) * feat: rename bn128 to bn254 for Ethereum standard consistency * fix: renamed more occurences * fix: addresed nits
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 21, 2026
…loy/revm#2810) * feat: rename bn128 to bn254 for Ethereum standard consistency * fix: renamed more occurences * fix: addresed nits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames
bn128tobn254for Ethereum standard consistencyChanges
Closes #2795