fix(op-revm): system tx not enveloped#2807
Merged
rakita merged 2 commits intobluealloy:mainfrom Jul 28, 2025
Merged
Conversation
emhane
commented
Jul 25, 2025
Comment on lines
-92
to
+100
| OpTransaction::new(TX::new_system_tx_with_caller( | ||
| let mut tx = OpTransaction::new(TX::new_system_tx_with_caller( | ||
| caller, | ||
| system_contract_address, | ||
| data, | ||
| )) | ||
| )); | ||
|
|
||
| tx.enveloped_tx = Some(Bytes::default()); | ||
|
|
||
| tx |
Contributor
Author
There was a problem hiding this comment.
I'm not sure if we need to be checking if this is pre-regolith here actually. I didn't find out how revm performs the actual eip2718 encoding since it seems alloy's impl can't be used here as revm has its own transaction trait ? @rakita
Member
There was a problem hiding this comment.
Revm does not perform eip2718 encoding, it is a field.
Calling replay on system "tx" is an undefined behaviour (as fields for this tx are undefined), so having empty bytes for envelop seems appropriate.
CodSpeed Performance ReportMerging #2807 will not alter performanceComparing Summary
|
This was referenced Jul 28, 2025
Closed
Closed
Closed
This was referenced Aug 4, 2025
Closed
Closed
Closed
Closed
Merged
lwedge99
pushed a commit
to sentioxyz/revm
that referenced
this pull request
Sep 16, 2025
* Fix bug, system tx not enveloped and add test * Fix lint
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 21, 2026
* Fix bug, system tx not enveloped and add test * Fix lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #2189
Bug: system tx not enveloped, triggering panic
"all not deposit tx have enveloped tx"in handler.Fix: sets enveloped tx equal to
Some(Bytes::default())Adds test covering
OpEvm::transact_system_call_with_caller, increasing coverage of op-revm/src/api/exec.rs from 59% to 79%.