Skip to content

Comments

chore: add OnceLock re-export with no_std support#2787

Merged
rakita merged 1 commit intobluealloy:mainfrom
DaniPopes:refactor-oncebox
Jul 24, 2025
Merged

chore: add OnceLock re-export with no_std support#2787
rakita merged 1 commit intobluealloy:mainfrom
DaniPopes:refactor-oncebox

Conversation

@DaniPopes
Copy link
Collaborator

Same as alloy_primitives::map that uses hashbrown, here we use once_cell::race::OnceBox for no_std OnceLock, while preferring std::sync::OnceLock.

@DaniPopes DaniPopes requested a review from rakita July 24, 2025 11:42
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 24, 2025

CodSpeed Performance Report

Merging #2787 will degrade performances by 3.11%

Comparing DaniPopes:refactor-oncebox (e92699c) with main (9c0a3d2)

Summary

❌ 1 regressions
✅ 170 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
transact_1000tx_commit_inner_every_40 2 ms 2.1 ms -3.11%

@DaniPopes
Copy link
Collaborator Author

Small regressions look like allocator/inlining noise

@rakita rakita merged commit 7f081bf into bluealloy:main Jul 24, 2025
29 of 30 checks passed
@DaniPopes DaniPopes deleted the refactor-oncebox branch July 24, 2025 12:06
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants