feat: Add remaining cryptography functions to CryptoTrait#2777
Closed
kevaundray wants to merge 12 commits intobluealloy:mainfrom
Closed
feat: Add remaining cryptography functions to CryptoTrait#2777kevaundray wants to merge 12 commits intobluealloy:mainfrom
kevaundray wants to merge 12 commits intobluealloy:mainfrom
Conversation
CodSpeed Performance ReportMerging #2777 will degrade performances by 3.75%Comparing Summary
Benchmarks breakdown
|
Contributor
Author
|
Checking the diff to implement all of them in one PR |
Contributor
Author
|
Removing the dynamic dispatch in f567bec removed the 3% regression -- so it seems that calling a round of blake2f is too cheap such that its performance is being affected by whether it is being statically called or via dynamic dispatch with non-inlining |
Contributor
Author
|
Superceded by #2786 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.