Skip to content

feat: Add remaining cryptography functions to CryptoTrait#2777

Closed
kevaundray wants to merge 12 commits intobluealloy:mainfrom
kevaundray:kw/add-bn128
Closed

feat: Add remaining cryptography functions to CryptoTrait#2777
kevaundray wants to merge 12 commits intobluealloy:mainfrom
kevaundray:kw/add-bn128

Conversation

@kevaundray
Copy link
Contributor

No description provided.

@kevaundray kevaundray marked this pull request as ready for review July 23, 2025 16:28
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 23, 2025

CodSpeed Performance Report

Merging #2777 will degrade performances by 3.75%

Comparing kevaundray:kw/add-bn128 (fe928af) with main (e6a25a3)

Summary

❌ 3 regressions
✅ 168 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
blake2/12_rounds 4.5 µs 4.6 µs -3.21%
blake2/2_rounds 3.1 µs 3.2 µs -3.75%
blake2/4_rounds 3.4 µs 3.5 µs -3.42%

@kevaundray
Copy link
Contributor Author

Checking the diff to implement all of them in one PR

@kevaundray kevaundray changed the title feat: Add bn128 to CryptoTrait feat: Add remaining cryptography functions to CryptoTrait Jul 23, 2025
@kevaundray
Copy link
Contributor Author

Removing the dynamic dispatch in f567bec removed the 3% regression -- so it seems that calling a round of blake2f is too cheap such that its performance is being affected by whether it is being statically called or via dynamic dispatch with non-inlining

@kevaundray
Copy link
Contributor Author

Superceded by #2786

@kevaundray kevaundray closed this Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant