chore: evaluate instruction table initializer at compile time#2762
Merged
rakita merged 1 commit intobluealloy:mainfrom Jul 23, 2025
Merged
chore: evaluate instruction table initializer at compile time#2762rakita merged 1 commit intobluealloy:mainfrom
rakita merged 1 commit intobluealloy:mainfrom
Conversation
Currently the instruction table is always initialized at runtime on the stack, which bloats the stack of functions that create an EVM and is generally slower. With this change the table gets compiled into a static and memcpy'd at runtime into the instruction table's Box.
6bb0187 to
d41f582
Compare
Collaborator
|
Nice -- this is the kind of change that I wonder why doesn't rust do by itself? |
CodSpeed Performance ReportMerging #2762 will not alter performanceComparing Summary
|
Collaborator
Author
|
Because it does what you tell it to, generally it won't evaluate something at compile time just because it's |
mattsse
approved these changes
Jul 23, 2025
rakita
approved these changes
Jul 23, 2025
This was referenced Jul 22, 2025
Closed
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the instruction table is always initialized at runtime on the stack, which bloats the stack of functions that create an EVM and is generally slower.
With this change the table gets compiled into a static and memcpy'd at runtime into the instruction table's Box.