Skip to content

chore: Add CryptoProvider trait + impl#2758

Closed
kevaundray wants to merge 18 commits intobluealloy:mainfrom
kevaundray:kw/add-dynamic-crypto-provider
Closed

chore: Add CryptoProvider trait + impl#2758
kevaundray wants to merge 18 commits intobluealloy:mainfrom
kevaundray:kw/add-dynamic-crypto-provider

Conversation

@kevaundray
Copy link
Contributor

@kevaundray kevaundray commented Jul 22, 2025

Based off of #2750 superecedes #2706 so the diff includes that:

  • Adds the CryptoProvider trait
  • Refactors cryptography calls to use the get_provider() method for cryptography code

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 22, 2025

CodSpeed Performance Report

Merging #2758 will degrade performances by 6.38%

Comparing kevaundray:kw/add-dynamic-crypto-provider (3d00601) with main (f501d00)

Summary

❌ 5 regressions
✅ 165 untouched benchmarks
⁉️ 1 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
blake2/10_rounds 4.3 µs 4.5 µs -4.65%
blake2/12_rounds 4.5 µs 4.7 µs -4.49%
blake2/2_rounds 3.1 µs 3.3 µs -6.38%
blake2/4_rounds 3.4 µs 3.6 µs -5.89%
⁉️ blake2/compress_12_rounds 3.3 µs N/A N/A
ecrecover precompile 196.9 µs 204.5 µs -3.74%

@kevaundray
Copy link
Contributor Author

Superceded by #2786

@kevaundray kevaundray closed this Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant