-
Notifications
You must be signed in to change notification settings - Fork 992
chore: move cryptography code into crypto folder
#2750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
edf5b23
move code
kevaundray 81f4147
Merge branch 'main' into kw/move-crypto-to-folder
kevaundray 498f841
fmt
kevaundray be9fa69
nit
kevaundray 6f026f2
remove export alias
kevaundray 64ae579
remove cryptography specific benchmark
kevaundray a6eca5d
add note about padding
kevaundray 6b6838e
add inline(always) for hash functions
kevaundray 5caec66
copy as_array
kevaundray 81643c9
move cfg to crypto specific sub-modules
kevaundray 2e9c377
move doc comment to crypto specific module
kevaundray 716de37
fmt
kevaundray acbbc5b
remove constants file
kevaundray 17c3d7e
remove mod.rs and use folder_name.rs
kevaundray 45bc468
Merge branch 'main' into kw/move-crypto-to-folder
kevaundray 5fbf864
Merge branch 'main' into kw/move-crypto-to-folder
kevaundray f17e3b0
Merge branch 'main' into kw/move-crypto-to-folder
kevaundray 6865ac1
copy PR
kevaundray 37ba2b9
Merge branch 'main' into kw/move-crypto-to-folder
kevaundray 8ab6d78
Merge branch 'main' into kw/move-crypto-to-folder
kevaundray File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might make sense to benchmark precompiles and the underlying cryptography separately -- we do still benchmark 12 rounds via the
runmethod so we don't lose much hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm precompiles is a crypto with a gas calculation.