refactor: remove generic impl for Host#2738
Merged
rakita merged 1 commit intobluealloy:mainfrom Jul 21, 2025
Merged
Conversation
CodSpeed Performance ReportMerging #2738 will not alter performanceComparing Summary
|
rakita
reviewed
Jul 21, 2025
Member
rakita
left a comment
There was a problem hiding this comment.
How would it look if we require ContextTr to implement Host ContextTr: Host?
Contributor
Author
|
@rakita Then there will be cycle dependency I think. The crate |
Member
Contributor
Author
|
@rakita Updated. Please see if it is appropriate. |
This was referenced Jul 22, 2025
Closed
Closed
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #2732.
The generic implementation for
revm::interpreter::Hostis replaced with an explicit implementation forrevm::context::Contextstruct type. This decoupling enables the specialization of host behavior for customized context types.PS: I added one dependency in the
revm-interpreter, making it additionally depend onrevm-context. I am not sure whether this dependency is appropriate or not, or whether there are other ways to do this.