chore: use EncodedPoint to decode uncompressed public key#2736
Merged
rakita merged 4 commits intobluealloy:mainfrom Jul 23, 2025
Merged
chore: use EncodedPoint to decode uncompressed public key#2736rakita merged 4 commits intobluealloy:mainfrom
EncodedPoint to decode uncompressed public key#2736rakita merged 4 commits intobluealloy:mainfrom
Conversation
kevaundray
commented
Jul 19, 2025
CodSpeed Performance ReportMerging #2736 will not alter performanceComparing Summary
|
Contributor
Author
|
PR is failing due to codspeed (unrelated) -- did this initial commit to show its a noop. The next commit applies the relevant changes |
kevaundray
changed the title
EncodedPoint to decode uncompressed public keyEncodedPoint to decode uncompressed public key
kevaundray
commented
Jul 19, 2025
Comment on lines
-65
to
-92
| // Prepend 0x04 to the public key: uncompressed form | ||
| let mut uncompressed_pk = [0u8; 65]; | ||
| uncompressed_pk[0] = 0x04; | ||
| uncompressed_pk[1..].copy_from_slice(pk); |
Contributor
Author
There was a problem hiding this comment.
The 0x04 was because of from_sec1_bytes -- using untagged_bytes means we don't need to do this and can avoid this allocation plus the validation of 0x04 tag
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
EncodedPointto decode the uncompressed public key. EncodedPoint allows us to bypass sec1 encoding and use the 64 bytes public key.