Merged
Conversation
CodSpeed Performance ReportMerging #2735 will not alter performanceComparing Summary
Benchmarks breakdown
|
kevaundray
commented
Jul 19, 2025
Comment on lines
+91
to
+111
| // Benchmark just the compression function with different round counts | ||
| group.bench_function("blake2/compress_12_rounds", |b| { | ||
| let h = [ | ||
| 0x6a09e667f3bcc908u64, | ||
| 0xbb67ae8584caa73bu64, | ||
| 0x3c6ef372fe94f82bu64, | ||
| 0xa54ff53a5f1d36f1u64, | ||
| 0x510e527fade682d1u64, | ||
| 0x9b05688c2b3e6c1fu64, | ||
| 0x1f83d9abfb41bd6bu64, | ||
| 0x5be0cd19137e2179u64, | ||
| ]; | ||
| let m = [0u8; 128]; | ||
| let t = [0u64, 0u64]; | ||
| b.iter(|| { | ||
| let mut h_copy = h; | ||
| blake2::algo::compress( | ||
| black_box(12), | ||
| &mut h_copy, | ||
| black_box(&m), | ||
| black_box(t), |
Contributor
Author
There was a problem hiding this comment.
can remove -- so we are only benchmarking the precompile in the way that it will be called
Member
There was a problem hiding this comment.
What was a reason for measuring 12 rounds. Is it to compare with other blake implementations?
Contributor
Author
There was a problem hiding this comment.
It was mainly because blake2b uses 12 rounds
This was referenced Jul 21, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.