chore: try arkworks-bls12-381 benchmarks#2329
Closed
kevaundray wants to merge 12 commits intobluealloy:mainfrom
Closed
chore: try arkworks-bls12-381 benchmarks#2329kevaundray wants to merge 12 commits intobluealloy:mainfrom
kevaundray wants to merge 12 commits intobluealloy:mainfrom
Conversation
kevaundray
commented
Mar 27, 2025
Comment on lines
-3
to
+11
| cfg_if::cfg_if! { | ||
| if #[cfg(feature = "blst")]{ | ||
| mod blst; | ||
| use blst as crypto_backend; | ||
| } else { | ||
| mod arkworks; | ||
| use arkworks as crypto_backend; | ||
| } | ||
| } | ||
| // cfg_if::cfg_if! { | ||
| // if #[cfg(feature = "blst")]{ | ||
| // mod blst; | ||
| // use blst as crypto_backend; | ||
| // } else { | ||
| // } | ||
| // } | ||
| mod arkworks; | ||
| use arkworks as crypto_backend; |
Contributor
Author
There was a problem hiding this comment.
main hack to essentially always enable arkworks
CodSpeed Performance ReportMerging #2329 will not alter performanceComparing Summary
Benchmarks breakdown
|
Contributor
Author
|
Closing since we have checked against arkworks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a PR to compare arkworks to blst.
It is based off of #2327