feat: provide more context to precompiles#2318
Merged
rakita merged 2 commits intobluealloy:mainfrom Mar 27, 2025
Merged
Conversation
bernard-wagner
force-pushed
the
custom-precompiles
branch
from
6db2109 to
09288b1
Compare
bernard-wagner
force-pushed
the
custom-precompiles
branch
from
09288b1 to
3ce2f17
Compare
CodSpeed Performance ReportMerging #2318 will not alter performanceComparing Summary
|
This was referenced Mar 27, 2025
Closed
Closed
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To provide greater support for custom precompiles, it would be useful to pass
InputsImplandis_statictoPrecompileProvider::runinstead of only a subset of the fields passed as inputs to the Interpreter. There are some use cases for custom chains that inspect the caller or should not be allowed in a static context (state-changing precompiles).