Skip to content

refactor: update EOF validation logic and improve error handling#2304

Merged
rakita merged 1 commit intobluealloy:mainfrom
jackwener:check_len
Mar 25, 2025
Merged

refactor: update EOF validation logic and improve error handling#2304
rakita merged 1 commit intobluealloy:mainfrom
jackwener:check_len

Conversation

@jackwener
Copy link
Contributor

  • line 54 don't check MAX_INITCODE_SIZE
  • use validate_raw_eof_inner to simplify Eof::decode+validate_eof_inner

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 25, 2025

CodSpeed Performance Report

Merging #2304 will not alter performance

Comparing jackwener:check_len (4893346) with main (3811df6)

Summary

✅ 8 untouched benchmarks

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice change!

@rakita rakita merged commit 78587df into bluealloy:main Mar 25, 2025
29 checks passed
@jackwener jackwener deleted the check_len branch March 25, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants