Bench with criterion by nemnem7 · Pull Request #2295 · bluealloy/revm

nemnem7 · 2025-03-24T17:00:00Z

Modified the body of functions which use criterion to do benchmark tests.
Added sample size field to Cmd struct
Renamed measurement_time field on Cmd struct to time
Modified evm.rs file

codspeed-hq · 2025-03-24T17:09:30Z

CodSpeed Performance Report

Merging #2295 will improve performances by ×3

_{Comparing nemnem7:bench_with_criterion (59a2ea3) with main (efe528e)}

Summary

⚡ 2 improvements
✅ 6 untouched benchmarks

Benchmarks breakdown

	Benchmark	`BASE`	`HEAD`	Change
⚡	`analysis`	178.3 µs	58.6 µs	×3
⚡	`transfer`	46.3 µs	25.1 µs	+84.81%

nemnem7 · 2025-03-24T17:11:58Z

@rakita

bins/revme/src/cmd/bench/burntpix.rs

bins/revme/src/cmd/bench/snailtracer.rs

bins/revme/src/cmd/bench/transfer.rs

bins/revme/src/cmd/bench.rs

…isions to the rest of the code

bins/revme/src/cmd/bench.rs

bins/revme/src/cmd/bench/burntpix.rs

rakita

few last nits but overall lgtm

nemnem7 · 2025-03-25T22:44:27Z

@rakita

nemnem7 · 2025-03-25T22:48:54Z

Removed the imports which were previously commented out.
Added comment which explains relationship and interaction between measurement_time and sample_size fields of Cmd struct
Adjusted default warmup time to 0.5s (was previously 0.1s)

* temp code preview * add criterion to benchmarks * added args to fn run() calls in bins/revme/ * modifed the code inside the benchmark tests * left only .replay function inside bench_functions and added minor revisions to the rest of the code * edited comment annotation in burntpix.rs file * added comments and set different default value for warm_up_time

* temp * feat: Add JournalInner * fix(ci): Still run statetests from eth/tests repo (#2306) * feat: Add a wrapper for arkworks for EIP196 (#2305) * add read_scalar, point_add and point_mul into the wrapper * modify bn128.rs to use new api methods * preserve previous semantics * initial commit to add matter-labs wrapper * feature gate matter-labs impl -- make substrate impl still default * update revm and precompile cargo.toml file * use cfg_if * make bn an optional dependency * cfg else -> else_if so that there is no silent fallback * follow same cfg_if pattern as other precompiles * fix optimism * add back `self` import * Push empty commit to trigger CI * cargo fmt * clippy fix * make `bn` the default with revm and revme * fix typo * Update crates/revm/Cargo.toml * Update crates/revm/Cargo.toml * Update crates/precompile/src/lib.rs * Update crates/optimism/Cargo.toml * revert Cargo.toml formatting * multi: - remove bn as optional - if default-features and matter-labs-eip1962 feature is enabled, then we choose matter-labs - remove conditional configs in other parts of code since bn is always available * revert crates/optimism/src/precompiles.rs * revert crates/optimism/src/evm.rs * revert unnecessary changes in crates/precompile/src/lib.rs * revert Cargo.toml changes * revert automatic Cargo.toml formatting * revert formatting on secp256k1 in Cargo.toml * revert c-kzg formatting in Cargo.toml * revert dev key in Cargo.toml * revert c-kzg feature in Cargo.toml * Update crates/precompile/Cargo.toml * Apply suggestions from code review * initial commit of arkworks file -- replace matter-labs * add arkworks depedency * grep replace matter-labs with arkworks * make substrate-bn impl optional * propagate arkworks/std * add comment for substrate-bn impl * Update crates/precompile/src/bn128/arkworks.rs --------- * feat: Add criterion to revme bench command (#2295) * temp code preview * add criterion to benchmarks * added args to fn run() calls in bins/revme/ * modifed the code inside the benchmark tests * left only .replay function inside bench_functions and added minor revisions to the rest of the code * edited comment annotation in burntpix.rs file * added comments and set different default value for warm_up_time * clear all Journal fields * doc * formating change --------- Co-authored-by: kevaundray <kevtheappdev@gmail.com> Co-authored-by: nemnem7 <115541090+nemnem7@users.noreply.github.com>

nemnem7 added 4 commits March 20, 2025 18:40

temp code preview

5294b96

add criterion to benchmarks

fdefcb4

added args to fn run() calls in bins/revme/

21077f4

modifed the code inside the benchmark tests

e9d9e8e