Skip to content

fix: ensure transactions succeed when balance check is disabled #2286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rakita merged 1 commit into from
Mar 25, 2025
Merged

fix: ensure transactions succeed when balance check is disabled #2286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions crates/handler/src/pre_execution.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ pub fn deduct_caller<CTX: ContextTr>(
let basefee = context.block().basefee();
let blob_price = context.block().blob_gasprice().unwrap_or_default();
let effective_gas_price = context.tx().effective_gas_price(basefee as u128);
let is_balance_check_disabled = context.cfg().is_balance_check_disabled();
let value = context.tx().value();

// Subtract gas costs from the caller's account.
// We need to saturate the gas cost to prevent underflow in case that `disable_balance_check` is enabled.
let mut gas_cost = (context.tx().gas_limit() as u128).saturating_mul(effective_gas_price);
Expand All @@ -70,6 +73,11 @@ pub fn deduct_caller<CTX: ContextTr>(
.balance
.saturating_sub(U256::from(gas_cost));

if is_balance_check_disabled {
// Make sure the caller's balance is at least the value of the transaction.
caller_account.info.balance = value.max(caller_account.info.balance);
}

// Bump the nonce for calls. Nonce for CREATE will be bumped in `handle_create`.
if is_call {
// Nonce is already checked
Expand Down
Loading