Skip to content

chore: add early exit for no-ops in EIP1962 and EIP2537#2271

Merged
rakita merged 2 commits intobluealloy:mainfrom
kevaundray:kw/early-exit-on-noops
Mar 21, 2025
Merged

chore: add early exit for no-ops in EIP1962 and EIP2537#2271
rakita merged 2 commits intobluealloy:mainfrom
kevaundray:kw/early-exit-on-noops

Conversation

@kevaundray
Copy link
Contributor

This PR avoids doing redundant work when the computation for the pairing or MSM will result in a no-op

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 20, 2025

CodSpeed Performance Report

Merging #2271 will not alter performance

Comparing kevaundray:kw/early-exit-on-noops (cfb2cb8) with main (02ecc88)

Summary

✅ 8 untouched benchmarks

@kevaundray kevaundray changed the title chore: add early exit for no-ops chore: add early exit for no-ops in EIP1962 and EIP2537 Mar 20, 2025
Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kevaundray kevaundray marked this pull request as ready for review March 21, 2025 12:28
@rakita rakita merged commit bba246d into bluealloy:main Mar 21, 2025
29 checks passed
This was referenced Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants