Skip to content

chore: Adds a wrapper around substrate-bn for EIP196#2258

Merged
rakita merged 4 commits intobluealloy:mainfrom
kevaundray:kw/ref-bn128
Mar 20, 2025
Merged

chore: Adds a wrapper around substrate-bn for EIP196#2258
rakita merged 4 commits intobluealloy:mainfrom
kevaundray:kw/ref-bn128

Conversation

@kevaundray
Copy link
Contributor

No description provided.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 19, 2025

CodSpeed Performance Report

Merging #2258 will not alter performance

Comparing kevaundray:kw/ref-bn128 (ff4f932) with main (8ed1b16)

Summary

✅ 8 untouched benchmarks

@kevaundray kevaundray marked this pull request as ready for review March 19, 2025 15:34
Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, good cleanup!

@kevaundray
Copy link
Contributor Author

This should hopefully make it a bit easier to swap out the bn128 library in the future because most of the API that a library needs to expose is contained in that substrate.rs file :)

@rakita
Copy link
Member

rakita commented Mar 20, 2025

This should hopefully make it a bit easier to swap out the bn128 library in the future because most of the API that a library needs to expose is contained in that substrate.rs file :)

Nice, this is something we need. We tried to integrate https://github.com/matter-labs/eip1962 behind the feature flag for std env, as it is faster, this would make this easier.

@rakita rakita merged commit 3c575e7 into bluealloy:main Mar 20, 2025
29 checks passed
This was referenced Mar 20, 2025
@kevaundray
Copy link
Contributor Author

This should hopefully make it a bit easier to swap out the bn128 library in the future because most of the API that a library needs to expose is contained in that substrate.rs file :)

Nice, this is something we need. We tried to integrate https://github.com/matter-labs/eip1962 behind the feature flag for std env, as it is faster, this would make this easier.

I can take a look at this -- we probably need to expose more methods to the wrapper

This was referenced Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants