chore: add documentation for the gas related constants for EIP2537#2246
Merged
rakita merged 2 commits intobluealloy:mainfrom Mar 19, 2025
Merged
chore: add documentation for the gas related constants for EIP2537#2246rakita merged 2 commits intobluealloy:mainfrom
rakita merged 2 commits intobluealloy:mainfrom
Conversation
CodSpeed Performance ReportMerging #2246 will not alter performanceComparing Summary
|
kevaundray
commented
Mar 18, 2025
Comment on lines
+31
to
+32
| /// Note: If `k` is more than the size of the discount table, then | ||
| /// the last value in the discount table is chosen. |
Contributor
Author
There was a problem hiding this comment.
This is also a coincidence imo -- Ideally we have a MAX_DISCOUNT constant like in the EIP instead of relying on the last value in the discount table to match the MAX_DISCOUNT constant
rakita
approved these changes
Mar 19, 2025
This was referenced Mar 19, 2025
Closed
Closed
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.