Skip to content

chore: fix clippy#2238

Merged
rakita merged 1 commit intobluealloy:mainfrom
kevaundray:kw/fix-clippy
Mar 18, 2025
Merged

chore: fix clippy#2238
rakita merged 1 commit intobluealloy:mainfrom
kevaundray:kw/fix-clippy

Conversation

@kevaundray
Copy link
Contributor

Blanket application of clippy

@kevaundray kevaundray marked this pull request as ready for review March 17, 2025 22:18
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 17, 2025

CodSpeed Performance Report

Merging #2238 will degrade performances by 3.2%

Comparing kevaundray:kw/fix-clippy (6ea2b2f) with main (5a2ff70)

Summary

❌ 1 regressions
✅ 7 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
precompile bench | ecrecover precompile 194.8 µs 201.3 µs -3.2%

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change! div_ceil was not present in rust when that code was made :D

@rakita rakita merged commit f480216 into bluealloy:main Mar 18, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants