refactor: make str to SpecId conversion fallible#2236
Merged
rakita merged 3 commits intobluealloy:mainfrom Mar 19, 2025
Merged
Conversation
CodSpeed Performance ReportMerging #2236 will not alter performanceComparing Summary
|
mattsse
previously requested changes
Mar 17, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
let's also do this for opspecid if missing
rakita
reviewed
Mar 19, 2025
This was referenced Mar 19, 2025
Closed
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches the way string to
SpecIdconversion is handled toOpSpecId, causing errors when invalid hardfork names are provided.