chore: Remove redundant bls12-381 constants and cleanup naming#2235
Merged
rakita merged 7 commits intobluealloy:mainfrom Mar 18, 2025
Merged
chore: Remove redundant bls12-381 constants and cleanup naming#2235rakita merged 7 commits intobluealloy:mainfrom
rakita merged 7 commits intobluealloy:mainfrom
Conversation
CodSpeed Performance ReportMerging #2235 will degrade performances by 2.7%Comparing Summary
Benchmarks breakdown
|
kevaundray
commented
Mar 17, 2025
| pub const PAIRING_OFFSET_BASE: u64 = 37700; | ||
| pub const MSM_MULTIPLIER: u64 = 1000; | ||
| // TODO: Why does this have PAIRING twice? | ||
| pub const PAIRING_PAIRING_MULTIPLIER_BASE: u64 = 32600; |
Contributor
Author
There was a problem hiding this comment.
Wasn't entirely sure why this was named PAIRING_PAIRING -- can revert if this was intentional
Member
There was a problem hiding this comment.
It was not intentional, it is good to have just one pairing in name
This was referenced Mar 18, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some constants were being used as aliases for other constants. This PR removes those aliases and directly references the underlying constant.
For example, instead of having a constant called G1_OUTPUT_LENGTH which will be used when we are outputting a G1 element, we instead just use G1_LENGTH and the fact that it is an output is inferred by it being a return type.