Skip to content

chore: add a safe blst wrapper#2223

Merged
rakita merged 22 commits intobluealloy:mainfrom
kevaundray:kw/blst-wrapper-refactor
Mar 18, 2025
Merged

chore: add a safe blst wrapper#2223
rakita merged 22 commits intobluealloy:mainfrom
kevaundray:kw/blst-wrapper-refactor

Conversation

@kevaundray
Copy link
Contributor

@kevaundray kevaundray commented Mar 16, 2025

This PR adds a safe blst wrapper and does a few miscellaneous cleanups, so leaving it in draft as it might be better to pull them out into separate PRs if the changes seem reasonable.

kevaundray added 11 commits March 16, 2025 21:19
@kevaundray
add blst wrapper
cafaa56
@kevaundray
add note on points at infinity
48d9522
@kevaundray
g1:
df3e31a 
- Move is_on_curve check into decode_and_check_g1 method (This should never be skipped)
- Opinionated: make the default extract_g1 method always do a subgroup check, so that it is harder to mess things up
@kevaundray
g2:
27dc5ae 
- Move is_on_curve check into decode_and_check_g2 method (This should never be skipped)
- Opinionated: make the default extract_g2 method always do a subgroup check, so that it is harder to mess things up
@kevaundray
g1_add:
ca0a723 
- refactor to use wrapper blst methods and be explicit about performing no subgroup check
@kevaundray
g2_add:
f6ef06d 
- refactor to use wrapper blst methods and be explicit about performing no subgroup check
@kevaundray
g1_msm:
65a30fc 
- refactor to use safe blst wrapper
- remove true argument to extract_g1_inputs since subgroup checks are on by default
- No longer need to convert to jacobian to affine and then back to affine
@kevaundray
g2_msm:
6584a9f 
- refactor to use safe blst wrapper
- remove true argument to extract_g2_inputs since subgroup checks are on by default
- No longer need to convert to jacobian to affine and then back to affine
@kevaundray
map_fp_to_g1:
b940940 
- use safe blst wrapper
@kevaundray
map_fp2_to_g2:
e06e9df 
- use safe blst wrapper
@kevaundray
pairing:
1a9d744 
- use safe blst wrapper
kevaundray
kevaundray commented Mar 16, 2025
View reviewed changes
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 16, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #2223 will not alter performance

Comparing kevaundray:kw/blst-wrapper-refactor (886f8a5) with main (f473029)

Summary

✅ 8 untouched benchmarks

@kevaundray kevaundray marked this pull request as ready for review March 17, 2025 16:21
kevaundray
kevaundray commented Mar 17, 2025
View reviewed changes
rakita
rakita reviewed Mar 18, 2025
View reviewed changes
rakita
rakita approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rakita rakita merged commit 7cc9939 into bluealloy:main Mar 18, 2025
29 checks passed
@github-actions github-actions bot mentioned this pull request Mar 18, 2025
Closed
This was referenced Mar 18, 2025
Closed
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rakita rakita rakita approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kevaundray @rakita