Skip to content

chore: Add some documentation for the bls12-381 precompile constants#2222

Merged
rakita merged 5 commits intobluealloy:mainfrom
kevaundray:kw/constants-doc-bls120381
Mar 17, 2025
Merged

chore: Add some documentation for the bls12-381 precompile constants#2222
rakita merged 5 commits intobluealloy:mainfrom
kevaundray:kw/constants-doc-bls120381

Conversation

@kevaundray
Copy link
Contributor

This PR adds some documentation for the BLS12-381 precompiles constants, in particular the ones related to the size of the inputs.

Currently in Draft because:

  • I have added a few TODOs related to some constants that seem to not be needed
  • I have added new lines between some constants and have not checked what is your preferred formatting rule
  • I have made an opinionated change to put all of the gas related constants together, whereas before they were interleaved with the cryptography related constants

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 16, 2025

CodSpeed Performance Report

Merging #2222 will not alter performance

Comparing kevaundray:kw/constants-doc-bls120381 (1666016) with main (8c10ab1)

Summary

✅ 8 untouched benchmarks

@rakita rakita marked this pull request as ready for review March 17, 2025 11:11
kevaundray and others added 2 commits March 17, 2025 11:48
Co-authored-by: rakita <rakita@users.noreply.github.com>
Co-authored-by: rakita <rakita@users.noreply.github.com>
@rakita rakita merged commit e3bc276 into bluealloy:main Mar 17, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants