PrecompileError removal from PrecompileProvider

crates/context/interface/src/result.rs

@@ -200,8 +200,6 @@ pub enum EVMError<DBError, TransactionError = InvalidTransaction> {
     ///
     /// Useful for handler registers where custom logic would want to return their own custom error.
     Custom(String),
-    /// Precompile error
-    Precompile(String),
 }
 
 impl<DBError: DBErrorMarker, TX> From<DBError> for EVMError<DBError, TX> {
@@ -236,7 +234,7 @@ impl<DBError, TransactionValidationErrorT> EVMError<DBError, TransactionValidati
             Self::Transaction(e) => EVMError::Transaction(e),
             Self::Header(e) => EVMError::Header(e),
             Self::Database(e) => EVMError::Database(op(e)),
-            Self::Precompile(e) => EVMError::Precompile(e),
+            // Self::Precompile(e) => EVMError::Precompile(e),
             Self::Custom(e) => EVMError::Custom(e),
         }
     }
@@ -253,7 +251,8 @@ where
             Self::Transaction(e) => Some(e),
             Self::Header(e) => Some(e),
             Self::Database(e) => Some(e),
-            Self::Precompile(_) | Self::Custom(_) => None,
+            // Self::Precompile(_) | Self::Custom(_) => None,
+            Self::Custom(_) => None,
         }
     }
 }
@@ -269,7 +268,8 @@ where
             Self::Transaction(e) => write!(f, "transaction validation error: {e}"),
             Self::Header(e) => write!(f, "header validation error: {e}"),
             Self::Database(e) => write!(f, "database error: {e}"),
-            Self::Precompile(e) | Self::Custom(e) => f.write_str(e),
+            // Self::Precompile(e) | Self::Custom(e) => f.write_str(e),
+            Self::Custom(e) => f.write_str(e),
         }
     }
 }

crates/handler/src/frame.rs

@@ -82,7 +82,7 @@ where
             InterpreterTypes = EthInterpreter,
         >,
     >,
-    ERROR: From<ContextTrDbError<EVM::Context>> + From<PrecompileError> + FromStringError,
+    ERROR: From<ContextTrDbError<EVM::Context>> + FromStringError,
 {
     type Evm = EVM;
     type FrameInit = FrameInput;
@@ -151,7 +151,7 @@ where
         Precompiles: PrecompileProvider<EVM::Context, Output = InterpreterResult>,
         Instructions: InstructionProvider,
     >,
-    ERROR: From<ContextTrDbError<EVM::Context>> + From<PrecompileError>,
+    ERROR: From<ContextTrDbError<EVM::Context>>,
 {
     /// Make call frame
     #[inline]
@@ -522,7 +522,7 @@ where
             InterpreterTypes = EthInterpreter,
         >,
     >,
-    ERROR: From<ContextTrDbError<EVM::Context>> + From<PrecompileError> + FromStringError,
+    ERROR: From<ContextTrDbError<EVM::Context>> + FromStringError,
 {
     pub fn init_first(
         evm: &mut EVM,

crates/handler/src/handler.rs

@@ -19,7 +19,6 @@ pub trait EvmTrError<EVM: EvmTr>:
     From<InvalidTransaction>
     + From<InvalidHeader>
     + From<<<EVM::Context as ContextTr>::Db as Database>::Error>
-    + From<PrecompileError>
     + FromStringError
 {
 }
@@ -29,7 +28,6 @@ impl<
         T: From<InvalidTransaction>
             + From<InvalidHeader>
             + From<<<EVM::Context as ContextTr>::Db as Database>::Error>
-            + From<PrecompileError>
             + FromStringError,
     > EvmTrError<EVM> for T
 {

crates/handler/src/precompile_provider.rs

@@ -20,7 +20,7 @@ pub trait PrecompileProvider<CTX: ContextTr> {
         address: &Address,
         bytes: &Bytes,
         gas_limit: u64,
-    ) -> Result<Option<Self::Output>, PrecompileError>;
+    ) -> Result<Option<Self::Output>, String>;
 
     /// Get the warm addresses.
     fn warm_addresses(&self) -> Box<impl Iterator<Item = Address>>;
@@ -76,7 +76,7 @@ impl<CTX: ContextTr> PrecompileProvider<CTX> for EthPrecompiles {
         address: &Address,
         bytes: &Bytes,
         gas_limit: u64,
-    ) -> Result<Option<InterpreterResult>, PrecompileError> {
+    ) -> Result<Option<InterpreterResult>, String> {
         let Some(precompile) = self.precompiles.get(address) else {
             return Ok(None);
         };
@@ -95,8 +95,8 @@ impl<CTX: ContextTr> PrecompileProvider<CTX> for EthPrecompiles {
                 result.output = output.bytes;
             }
             Err(e) => {
-                if let PrecompileError::Fatal(_) = e {
-                    return Err(e);
+                if let PrecompileError::Fatal(msg) = e {
+                    return Err(msg);
                 }
                 result.result = if e.is_oog() {
                     InstructionResult::PrecompileOOG

crates/inspector/src/traits.rs

@@ -86,7 +86,7 @@ where
                 InterpreterTypes = EthInterpreter,
             >,
         > + InspectorEvmTr,
-    ERROR: From<ContextTrDbError<EVM::Context>> + From<PrecompileError> + FromStringError,
+    ERROR: From<ContextTrDbError<EVM::Context>> + FromStringError,
 {
     type IT = EthInterpreter;
 

examples/erc20_gas/src/main.rs

@@ -87,7 +87,6 @@ where
     ERROR: From<InvalidTransaction>
         + From<InvalidHeader>
         + From<<CTX::Db as Database>::Error>
-        + From<PrecompileError>,
 {
     let sender_balance_slot = erc_address_storage(sender);
     let sender_balance = context.journal().sload(TOKEN, sender_balance_slot)?.data;