feat: allow reuse of API for calculating initial tx gas for tx#2215
Merged
rakita merged 2 commits intobluealloy:mainfrom Mar 17, 2025
Merged
feat: allow reuse of API for calculating initial tx gas for tx#2215rakita merged 2 commits intobluealloy:mainfrom
rakita merged 2 commits intobluealloy:mainfrom
Conversation
15 tasks
Wodann
force-pushed
the
refactor/calc-initial-gas
branch
from
e577394 to
d1572ab
Compare
CodSpeed Performance ReportMerging #2215 will not alter performanceComparing Summary
|
rakita
changed the title
Wodann
force-pushed
the
refactor/calc-initial-gas
branch
from
65b765a to
4353dc9
Compare
Contributor
Author
Rebased, resolving the conflict. |
This was referenced Mar 17, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
InvalidTransaction::CallGasCostMoreThanGasLimitandInvalidTransaction::GasFloorMoreThanGasLimit, such that we can inform the user - in the error message - about which values they should use to make their transaction valid.calculate_initial_tx_gas_for_txfunction so it can be reusedIf approved, this PR should be applied after #2214, as it depends on the change made there.