Return Fatal error on bls precompiles if in no_std #2208#2210
Closed
Ayushdubey86 wants to merge 2 commits intobluealloy:mainfrom
Closed
Return Fatal error on bls precompiles if in no_std #2208#2210Ayushdubey86 wants to merge 2 commits intobluealloy:mainfrom
Ayushdubey86 wants to merge 2 commits intobluealloy:mainfrom
Conversation
CodSpeed Performance ReportMerging #2210 will not alter performanceComparing Summary
|
rakita
reviewed
Mar 14, 2025
| map_fp2_to_g2::PRECOMPILE, | ||
| ] | ||
| .into_iter() | ||
| cfg_if! { |
Member
There was a problem hiding this comment.
This is in the wrong place it should be in fn prague function
rakita
reviewed
Mar 14, 2025
| if #[cfg(not(feature = "std"))] { // If no_std is enabled | ||
| vec
Member
|
Superseded in #2249 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of now , i have added if condition globally to all precompile together, as i working on issue but if you feel the need of more personal error like "c-kzg feature is not enabled" , I'll push it within this pr itself