Skip to content

Comments

chore(precompile): Refactor out MSM Helper#2179

Merged
rakita merged 1 commit intobluealloy:mainfrom
refcell:rf/refactor-out-msm-helper
Mar 11, 2025
Merged

chore(precompile): Refactor out MSM Helper#2179
rakita merged 1 commit intobluealloy:mainfrom
refcell:rf/refactor-out-msm-helper

Conversation

@refcell
Copy link
Contributor

@refcell refcell commented Mar 10, 2025

Description

Refactor out the msm_required_gas method for re-use in kona. Pulling msm_required_gas into a non-blst feature flag gated module allows kona to use the method in a no_std environment instead of having a duplicated method.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 11, 2025

CodSpeed Performance Report

Merging #2179 will improve performances by 2.7%

Comparing refcell:rf/refactor-out-msm-helper (57d15c0) with main (9e39df5)

Summary

⚡ 1 improvements
✅ 7 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
precompile bench | ecrecover precompile 200.2 µs 194.9 µs +2.7%

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rakita rakita merged commit 9011820 into bluealloy:main Mar 11, 2025
29 checks passed
This was referenced Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants