refactor: remove CTX phantomdata from precompile providers#2178
Merged
Conversation
klkvr
force-pushed
the
klkvr/precompile-generics
branch
from
805a682 to
2015973
Compare
CodSpeed Performance ReportMerging #2178 will not alter performanceComparing Summary
|
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now
EthPrecompilesandOpPrecompileProviderhave a CTX generic and PhantomData. This is not neccesarry and is sometimes bad because we can't reuse the same provider object for different databases.The PR adds
CTXgeneric toPrecompileProvidertrait instead and removes phantomdatas from those types.Also,
OpPrecompileProvideris renamed toOpPrecompilesto follow eth naming