Skip to content

Comments

refactor: simplify bn128::run_pair#2137

Merged
rakita merged 1 commit intobluealloy:mainfrom
JackDrogon:refactor/simplify_bn128_run_pair
Mar 4, 2025
Merged

refactor: simplify bn128::run_pair#2137
rakita merged 1 commit intobluealloy:mainfrom
JackDrogon:refactor/simplify_bn128_run_pair

Conversation

@JackDrogon
Copy link
Contributor

simplify bn128::run_pair

Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 4, 2025

CodSpeed Performance Report

Merging #2137 will degrade performances by 2.44%

Comparing JackDrogon:refactor/simplify_bn128_run_pair (6cbc191) with main (55a3e8f)

Summary

❌ 1 regressions
✅ 7 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
precompile bench | ecrecover precompile 195.5 µs 200.4 µs -2.44%

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rakita rakita merged commit a6e3bba into bluealloy:main Mar 4, 2025
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants