Revert "Split precompile constants out of individual modules #2081"#2101
Closed
Revert "Split precompile constants out of individual modules #2081"#2101
Conversation
This reverts commit 02c9b67.
CodSpeed Performance ReportMerging #2101 will not alter performanceComparing Summary
|
Member
|
Will close this as bugs have been fixed here: #2102 and CI for prague is enabled |
rakita
deleted the
revert-2085-Split-Precompile-Constants-out-of-Individual-Modules-#2081
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2085
this change introduced a bug, we should start over here and do it right