Skip to content

Comments

refactor: remove OpSpec#2074

Merged
rakita merged 5 commits intomainfrom
klkvr/op-spec
Feb 12, 2025
Merged

refactor: remove OpSpec#2074
rakita merged 5 commits intomainfrom
klkvr/op-spec

Conversation

@klkvr
Copy link
Collaborator

@klkvr klkvr commented Feb 12, 2025

Removes OpSpec enum and uses OpSpecId directly

Additionally derived Default on it


pub const fn is_enabled_in(self, other: OpSpecId) -> bool {
self as u8 <= other as u8
other as u8 <= self as u8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good find

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

catched by tests below :)

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 12, 2025

CodSpeed Performance Report

Merging #2074 will improve performances by 2.15%

Comparing klkvr/op-spec (a94bc40) with main (4f2059c)

Summary

⚡ 1 improvements
✅ 7 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
precompile bench | ecrecover precompile 204.6 µs 200.3 µs +2.15%

@rakita rakita merged commit b67ca3e into main Feb 12, 2025
28 checks passed
@github-actions github-actions bot mentioned this pull request Feb 12, 2025
@rakita rakita deleted the klkvr/op-spec branch February 12, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants