feat: extract and export estimate_tx_compressed_size#1985
Merged
rakita merged 2 commits intobluealloy:mainfrom Jan 10, 2025
Merged
feat: extract and export estimate_tx_compressed_size#1985rakita merged 2 commits intobluealloy:mainfrom
estimate_tx_compressed_size#1985rakita merged 2 commits intobluealloy:mainfrom
Conversation
CodSpeed Performance ReportMerging #1985 will not alter performanceComparing Summary
|
rakita
reviewed
Jan 10, 2025
Member
rakita
left a comment
There was a problem hiding this comment.
lgtm! Maybe it makes sense to move all tx_ to transaction.rs as they depend mostly on input
Crates should be released in upcoming weeks. Currently, there is a branch where old API is still maintained for projects that didn't integrate with main.
rakita
approved these changes
Jan 10, 2025
This was referenced Feb 7, 2025
Closed
Closed
This was referenced Mar 4, 2025
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow calling
estimate_tx_compressed_sizefor the purpose of adding DA size limits to the OP sequencer. Example usage here: https://github.com/paradigmxyz/reth/pull/13757/files#diff-fc959a93a8c46daf00cdff39ee39f8c1c18d36cd482a50a300294000cea38c37R82I can also move this function to a separate file if that's desired - just lmk!
Also, I'm assuming we'll publish this package on the next release? I don't see a
revm-optimismpackage on crates.io yet.