typo: fix comments and docs into more sensible#1920
Merged
rakita merged 6 commits intobluealloy:mainfrom Dec 20, 2024
Merged
Conversation
Contributor
Author
Member
|
Will check it out, amazing work btw! |
lancorer
force-pushed
the
fix-comments-typo-and-doc
branch
from
9021f36 to
67d68d9
Compare
Contributor
Author
|
@rakita |
rakita
reviewed
Dec 20, 2024
rakita
reviewed
Dec 20, 2024
rakita
reviewed
Dec 20, 2024
...sts/prague/eip7692_eof_v1/eip7620_eof_create/eofcreate_failures/eof_eofcreate_msg_depth.json
Show resolved
Hide resolved
rakita
reviewed
Dec 20, 2024
rakita
reviewed
Dec 20, 2024
..._suite/eest/state_tests/prague/eip7692_eof_v1/eip7069_extcall/calls/eof_calls_msg_depth.json
Show resolved
Hide resolved
rakita
reviewed
Dec 20, 2024
Member
|
@lancorer what did you use to make this change? |
rakita
approved these changes
Dec 20, 2024
Member
rakita
left a comment
rakita
left a comment
There was a problem hiding this comment.
lgtm! Pending merge and reverting of few files.
Contributor
Author
Just editor lol |
lancorer
force-pushed
the
fix-comments-typo-and-doc
branch
from
67d68d9 to
a388df2
Compare
Member
lol, amazing! |
Contributor
Author
|
@rakita |
lancorer
force-pushed
the
fix-comments-typo-and-doc
branch
from
2b7d613 to
6129de9
Compare
added 2 commits
December 20, 2024 04:37
This was referenced Dec 20, 2024
Closed
This was referenced Dec 20, 2024
Closed
This was referenced Dec 31, 2024
This was referenced Feb 7, 2025
Closed
Closed
This was referenced Mar 4, 2025
Closed
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Started from updating this line:
revm/crates/bytecode/src/eof/header.rs
Line 12 in 3774f6e
But analyzing over 4000 whole comments!
Solution
Tasks
//comments.///comments.