fix(revme): use Osaka for state test results#1844
Closed
Rjected wants to merge 3 commits intobluealloy:mainfrom
Closed
fix(revme): use Osaka for state test results#1844Rjected wants to merge 3 commits intobluealloy:mainfrom
Rjected wants to merge 3 commits intobluealloy:mainfrom
Conversation
we must be using the version with both values for some reason, so instead let's use the osaka value (afaik it should be the same?)
Collaborator
Author
|
Closing this, I think there's more work needed for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two
ethereum/testscommits:ethereum/tests@6e878df (adds osaka)
ethereum/tests@4c87ebb (removes prague)
changed the result key from
PraguetoOsaka, so we change it here as wellopened this to fix the statetest CI, which is failing in #1843