chore: Refactor code, and check if precompile for create collision#1600
Merged
chore: Refactor code, and check if precompile for create collision#1600
Conversation
Contributor
|
Valgrind Results: |
This was referenced Jul 10, 2024
Closed
Closed
Closed
Closed
Merged
j75689
pushed a commit
to j75689/revm
that referenced
this pull request
Aug 1, 2024
…luealloy#1600) * chore: Refactor code, and check is precompile for create colision * remove some TODOs for eofcreate nonce
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
warm_preloaded_addresseswas used for create collision check. That made sense when it was the list of precompile addresses but with new usage, this is incorrect.Moves creating of frame from inner context to Context.