chore(revm): defer bytecode load

[lightsing]

Current revm try to load bytecode just after depth check, but there are some conditions the code is not needed:

• insufficient balance to transfer
• call to a precompile address

As long as the code is not needed, the database provider may not have corresponding code, like in our implementation scroll-tech/stateless-block-verifier#15 use this as an optimization.

[rakita]

Looks reasonable, will check it again to be sure

[rakita]

Suggested change

	if !bytecode.is_empty() {
	let contract = Contract::new_with_context(
	inputs.input.clone(),
	bytecode,
	Some(code_hash),
	inputs,
	);
	// Create interpreter and executes call and push new CallStackFrame.
	Ok(FrameOrResult::new_call_frame(
	inputs.return_memory_offset.clone(),
	checkpoint,
	Interpreter::new(contract, gas.limit(), inputs.is_static),
	))
	} else {
	self.journaled_state.checkpoint_commit();
	return_result(InstructionResult::Stop)
	}
	if bytecode.is_empty() {
	self.journaled_state.checkpoint_commit();
	return_result(InstructionResult::Stop)
	}
	let contract = Contract::new_with_context(
	inputs.input.clone(),
	bytecode,
	Some(code_hash),
	inputs,
	);
	// Create interpreter and executes call and push new CallStackFrame.
	Ok(FrameOrResult::new_call_frame(
	inputs.return_memory_offset.clone(),
	checkpoint,
	Interpreter::new(contract, gas.limit(), inputs.is_static),
	))

code style nit. Maybe it needs fmt

[rakita]

This is slightly an edge case that is not a consensus error but would fix it to be consistent. CALL from instruction loads account that makes account warm loaded, while if we do it from tx as in TransactTo this is not the case, this is really a edge case where it is noticeable only that account will not be returned from finalization and only if tx is calling precompile.

We can add here load_account in place of load_code, something like let _ = self...load_acccount(..)?

[rakita]

Left comment, and one nit

[rakita]

lgtm