Skip to content

Comments

feat(Prague): Add EIP-7702#1565

Merged
rakita merged 14 commits intomainfrom
rakita/eip7702
Jun 28, 2024
Merged

feat(Prague): Add EIP-7702#1565
rakita merged 14 commits intomainfrom
rakita/eip7702

Conversation

@rakita
Copy link
Member

@rakita rakita commented Jun 24, 2024 •
edited
Loading

Waiting for alloy-rs/alloy#950

onbjerg
onbjerg reviewed Jun 24, 2024
View reviewed changes
crates/primitives/src/env.rs
if self.tx.authorization_list.is_some() {
// Check if other fields are unset.
if self.tx.max_fee_per_blob_gas.is_some() || !self.tx.blob_hashes.is_empty() {
return Err(InvalidTransaction::AuthorizationListInvalidFields);
Copy link
Collaborator

@onbjerg onbjerg Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this not be BlobVersionedHashesNotSupported? or something similar, this error is a bit vague since the error is that we have an auth list and blobs

Copy link
Member Author

@rakita rakita Jun 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, EnvTx sucks rn, as we have all fields in one struck. This error marks AuthorizationList TX which has set some fields by mistake.

onbjerg
onbjerg reviewed Jun 24, 2024
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2024 •
edited
Loading

Valgrind Results:

==3923== Cachegrind, a cache and branch-prediction profiler
==3923== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==3923== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==3923== Command: target/release/snailtracer
==3923== 
--3923-- warning: L3 cache found, using its data for the LL simulation.
Running snailtracer example!
elapsed: 1.829990925s
==3923== 
==3923== I   refs:      427,039,778
==3923== I1  misses:          4,350
==3923== LLi misses:          2,802
==3923== I1  miss rate:        0.00%
==3923== LLi miss rate:        0.00%
==3923== 
==3923== D   refs:      204,076,924  (132,268,766 rd   + 71,808,158 wr)
==3923== D1  misses:        344,823  (    204,875 rd   +    139,948 wr)
==3923== LLd misses:        137,805  (      4,488 rd   +    133,317 wr)
==3923== D1  miss rate:         0.2% (        0.2%     +        0.2%  )
==3923== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==3923== 
==3923== LL refs:           349,173  (    209,225 rd   +    139,948 wr)
==3923== LL misses:         140,607  (      7,290 rd   +    133,317 wr)
==3923== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@rakita rakita requested a review from onbjerg June 24, 2024 19:26
@rakita
Copy link
Member Author

rakita commented Jun 24, 2024

@onbjerg this should be okay to go. Need alloy-rs/alloy#964 and a new version of alloy-eips to be published. Have patches and disabled alloy as it has dependencies.

onbjerg
onbjerg approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rakita rakita merged commit 64dc252 into main Jun 28, 2024
This was referenced Jun 28, 2024
Closed
Closed
Merged
@rakita rakita deleted the rakita/eip7702 branch June 30, 2024 20:17
@Brechtpd Brechtpd mentioned this pull request Jul 19, 2024
Closed
1 task
@github-actions github-actions bot mentioned this pull request Feb 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@onbjerg onbjerg onbjerg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rakita @onbjerg