chore: store tokio::runtime::Handle in ethers/alloyDB#1557
Merged
rakita merged 5 commits intobluealloy:mainfrom Jun 28, 2024
Merged
chore: store tokio::runtime::Handle in ethers/alloyDB#1557rakita merged 5 commits intobluealloy:mainfrom
rakita merged 5 commits intobluealloy:mainfrom
Conversation
DaniPopes
requested changes
Jun 21, 2024
mattsse
previously requested changes
Jun 21, 2024
DaniPopes
approved these changes
Jun 23, 2024
rakita
approved these changes
Jun 28, 2024
Closed
Contributor
|
@rakita This change is not appropriate. If you wish to enforce ethersdb/alloydb to always play with async world, you should mark @DaniPopes I disagree with not allowing ethersdb/alloydb to create current thread runtime. This makes them totally incompatible with sync world and creating a current thread runtime is rather cheap. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #1534